search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
53 stars 52 forks source link

[MRG] update to Python>=3.8 #678

Closed rythorpe closed 11 months ago

rythorpe commented 11 months ago

The latest releases of Matplotlib now require Python>=3.8. This updates our tests and installers correspondingly.

rythorpe commented 11 months ago

Okay, I'm pretty sure everything should pass now. Feel free to squash and merge if/when it does @ntolley @jasmainak so we can build and update our docs on master.

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (91b8ff6) 91.42% compared to head (4d5ccf4) 91.38%.

:exclamation: Current head 4d5ccf4 differs from pull request most recent head 9205e61. Consider uploading reports for the commit 9205e61 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #678 +/- ## ========================================== - Coverage 91.42% 91.38% -0.04% ========================================== Files 25 25 Lines 4604 4599 -5 ========================================== - Hits 4209 4203 -6 - Misses 395 396 +1 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/jonescompneurolab/hnn-core/pull/678/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jonescompneurolab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jasmainak commented 11 months ago

I enabled auto-merge. Thanks a lot @rythorpe !! 🎉

rythorpe commented 11 months ago

How do we change the merge requirements @jasmainak? Right now you're the only one who can approve merges or enable auto-merges.

jasmainak commented 11 months ago

Umm ... I think anyone with merge rights can enable auto-merges ... but if the CIs are not passing, you have to select "Merge without waiting for requirements to be met". I would select this sparingly though ...

jasmainak commented 11 months ago

The macos build seems to be stuck for whatever reason ...

rythorpe commented 11 months ago

Did you disable auto-merge on purpose @jasmainak, or did it cancel when you modified the branch protection rules?

rythorpe commented 11 months ago

I'm guessing it just cancelled on its own so I went ahead and merged it :rocket:

jasmainak commented 11 months ago

Thanks @rythorpe !