search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
55 stars 52 forks source link

[MRG] Update error message for adding drives #681

Closed tianqi-cheng closed 1 year ago

tianqi-cheng commented 1 year ago

Closes #668.

Added "Please delete the L5_basket part from the code." to the error message.

ntolley commented 1 year ago

This is looking good @tianqi-cheng!

Take a look at the PR description, I edited it to say "Closes #668" on the first line. We do this so that we can keep track of which issue this PR is addressing.

Github also pulls a little magic and will automatically close the issue when this PR is merged when you add that line

ntolley commented 1 year ago

Also we didn't get a chance to talk about unit tests (we will this Wednesday), but if you click on the "details" for the units tests you can get information on what's failing

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7bebb00) 91.38% compared to head (f1d24f2) 91.38%.

:exclamation: Current head f1d24f2 differs from pull request most recent head 3dcaa33. Consider uploading reports for the commit 3dcaa33 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #681 +/- ## ======================================= Coverage 91.38% 91.38% ======================================= Files 25 25 Lines 4599 4599 ======================================= Hits 4203 4203 Misses 396 396 ``` | [Files](https://app.codecov.io/gh/jonescompneurolab/hnn-core/pull/681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jonescompneurolab) | Coverage Δ | | |---|---|---| | [hnn\_core/drives.py](https://app.codecov.io/gh/jonescompneurolab/hnn-core/pull/681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jonescompneurolab#diff-aG5uX2NvcmUvZHJpdmVzLnB5) | `98.52% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ntolley commented 1 year ago

Congrats on the first PR @tianqi-cheng!!

Quick note for future PR's, we typically change the title from WIP to [MRG] when we've made all the changes. It's also a way to signal to us that the PR is ready to be reviewed

jasmainak commented 1 year ago

@tianqi-cheng you don't have your git set up properly. The commits don't link back to your profile. You should set up the email address correctly. @ntolley can guide you!

tianqi-cheng commented 1 year ago

@tianqi-cheng you don't have your git set up properly. The commits don't link back to your profile. You should set up the email address correctly. @ntolley can guide you!

Thank you for the suggestion! I will ask Nick about that.