Closed tianqi-cheng closed 11 months ago
This is looking good @tianqi-cheng!
Take a look at the PR description, I edited it to say "Closes #668" on the first line. We do this so that we can keep track of which issue this PR is addressing.
Github also pulls a little magic and will automatically close the issue when this PR is merged when you add that line
Also we didn't get a chance to talk about unit tests (we will this Wednesday), but if you click on the "details" for the units tests you can get information on what's failing
All modified lines are covered by tests :white_check_mark:
Comparison is base (
7bebb00
) 91.38% compared to head (f1d24f2
) 91.38%.:exclamation: Current head f1d24f2 differs from pull request most recent head 3dcaa33. Consider uploading reports for the commit 3dcaa33 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Congrats on the first PR @tianqi-cheng!!
Quick note for future PR's, we typically change the title from WIP
to [MRG]
when we've made all the changes. It's also a way to signal to us that the PR is ready to be reviewed
@tianqi-cheng you don't have your git set up properly. The commits don't link back to your profile. You should set up the email address correctly. @ntolley can guide you!
@tianqi-cheng you don't have your git set up properly. The commits don't link back to your profile. You should set up the email address correctly. @ntolley can guide you!
Thank you for the suggestion! I will ask Nick about that.
Closes #668.
Added "Please delete the L5_basket part from the code." to the error message.