Closed tianqi-cheng closed 4 months ago
@rythorpe @jasmainak we decided to just cherry-pick from the old PR since it was paused so long ago (and we didn't have access to push to the PR directly)
@rythorpe Hi Ryan, do you think I addressed the issues properly?
This looks good @tianqi-cheng. The next steps will be to resolve my minor comments below and add a deprecation warning + updating
whats_new.rst
based on @jasmainak's recommendation.One other issue I anticipate we'll need to address before merging is that
CellResponse
instances read in from spike files don't set theCellResponse.times
attribute. Since the code below relies on this attribute always being defined, we'll need to find a fix for this.
Thanks! I will work on it.
Hey, I have now taken on this pull request. I'm thinking about the options for the deprecation cycle of defining tmin and tmax for plot_dipole et al.
Continues the PR #604. Closes the issue #544.