search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
53 stars 52 forks source link

tests: add axis data checks for all plots available in GUI #697

Closed gtdang closed 5 months ago

gtdang commented 8 months ago

Add checks to test_gui.py to make sure all GUI plots actually plot data on the axis. See #695 for the added checks on the default plots. Currently there are no checks (aside from the default plots) to make sure plots are not empty. Empty plots can occur when an error occurs between clicking the plot/run button and the GUI calling the plot function from the viz module.

The default figures are the figures that are automatically generated after running a simulation. The figures that need to be checked are the figures that the user can manually create using the Visualization tab. See image below. Screenshot 2024-03-12 at 10 33 34 AM

Of this list "current dipole" and "histogram" don't need checks as they are part of the default set of plots. The others will need to have unique test functions developed except for the spectrogram, which already has a unique test test_gui_adaptive_spectrogram. However the spectrogram does need to have a check for if data is plotted.

jasmainak commented 8 months ago

Absolutely ... PR is welcome!

samadpls commented 5 months ago

@jasmainak, can I take this issue? 😋

samadpls commented 5 months ago

Closed via #726 - task completed.