search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
54 stars 52 forks source link

WIP: refactoring hard coded parts in renaming cells in HNN #702

Open wagdy88 opened 9 months ago

wagdy88 commented 9 months ago

Work in Progress to refactor the hard-coded parts in the code for renaming cells in HNN.

rythorpe commented 9 months ago

Glad to see you got everything setup @wagdy88! Next step is to start working through Network class to get it to create an instance with your updated cell name without throwing any errors. For starters, we might want to consider moving _create_cell_coords to within the Network class so that it can access the Network.cell_types automatically.

rythorpe commented 9 months ago

Then, you could refactor the logic for assigning a cell's position within the column according to cell.name. The idea is that the keys of Network.cell_types correspond to cells' network-level names, which are mutable, but that an individual cell's name attribute corresponds to it's cell-level name and should remain immutable because this value determines where it gets placed within the network.