Closed gtdang closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d3dd255
) 91.35% compared to head (5df2214
) 91.35%.:exclamation: Current head 5df2214 differs from pull request most recent head 4657b5c. Consider uploading reports for the commit 4657b5c to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@gtdang this looks great!
Before I forget, you should add this to whats_new.rst
, as well as #696 (under bug fix?)
@gtdang you should make a branch to your own fork, not to the main repo. For now it's okay, just remember to delete dev-extras
branch after the pull request is merged.
@gtdang this looks great!
Before I forget, you should add this to
whats_new.rst
, as well as #696 (under bug fix?)
Thanks! Updated with the whats_new.rst with PRs #695 #696 and the current #703
@gtdang I enabled auto-merge. Don't forget to delete the dev-extras
branch once you are done since it's on upstream
Thanks a lot for your contributions 🙏 🥳
This is a small PR to improve the classification & organization of extra dependencies. The key benefits to this change are:
pip install -e '.[dev]'
, to get all the dependencies for joblib, GUI, test, docs generation.Note:
parallel
group. So developers will still need to manually install mpi4py and openmpi as recommended in the contributor guide.To do: