search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
51 stars 50 forks source link

[MRG] Updates to network read and write #704

Closed gtdang closed 5 months ago

gtdang commented 6 months ago

Working PR to update network HDF5 read and write.

gtdang commented 5 months ago

@ntolley Got all the tests working on this PR. There's still one outstanding comment about an edge case. Any thoughts on that? Other than that a final review of the test in io_test.py would be good before merge.

codecov-commenter commented 5 months ago

Codecov Report

Attention: 187 lines in your changes are missing coverage. Please review.

Comparison is base (d3dd255) 91.35% compared to head (1ab1329) 89.06%. Report is 30 commits behind head on network-rw.

:exclamation: Current head 1ab1329 differs from pull request most recent head 264266d. Consider uploading reports for the commit 264266d to get more accurate results

Files Patch % Lines
hnn_core/io.py 0.00% 175 Missing :warning:
hnn_core/hnn_io.py 96.37% 5 Missing :warning:
hnn_core/cell.py 94.59% 4 Missing :warning:
hnn_core/extracellular.py 90.90% 2 Missing :warning:
hnn_core/network.py 98.46% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## network-rw #704 +/- ## ============================================== - Coverage 91.35% 89.06% -2.30% ============================================== Files 25 28 +3 Lines 4606 5068 +462 ============================================== + Hits 4208 4514 +306 - Misses 398 554 +156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ntolley commented 5 months ago

@gtdang great work!!! :tada: :tada: