Closed ntolley closed 8 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
1216038
) 91.34% compared to head (1f25b11
) 91.36%. Report is 46 commits behind head on master.:exclamation: Current head 1f25b11 differs from pull request most recent head 3a069cd. Consider uploading reports for the commit 3a069cd to get more accurate results
Files | Patch % | Lines |
---|---|---|
hnn_core/gui/_viz_manager.py | 83.87% | 5 Missing :warning: |
hnn_core/gui/gui.py | 92.30% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@gtdang finally got the tests passing! just updated whats_new.rst
, merge button is yours once the checks are green
@gtdang finally got the tests passing! just updated
whats_new.rst
, merge button is yours once the checks are green
Awesome! Great job!
Thanks @gtdang and @ntolley for taking this through!
As discussed in #704, we've realized that it is necessary to have an explicit API fro defining the size of the network object. Previously this was done in a hacky way by directly editing the
params
object. The proposed API here is