GUI plotting observed data on PSD plot

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates

https://jonescompneurolab.github.io/hnn-core/

BSD 3-Clause "New" or "Revised" License

55 stars 52 forks source link

GUI plotting observed data on PSD plot #714

Open gtdang opened 9 months ago

gtdang commented 9 months ago

Ability to plot observed data PSD over simulated data PSD

Section 5 - Figure 17 of the Alpha/Beta tutorial (see below) shows how to compare PSD between simulated and observed data. The observed data PSD is added to the existing plot with std error bounds. This feature should be added to the new GUI.

jasmainak commented 7 months ago

This is a problematic feature to add ... actual data will have 1/f ... unless you remove that somehow, it's not easily comparable. @rythorpe @ntolley any accepted way how jones lab addresses this?

gtdang commented 7 months ago

Added the figure from the past tutorial in the description for reference. Curious how this was handled with the previous GUI?

rythorpe commented 7 months ago

The empirical PSD must have been normalized somehow, though I'm not sure what convention was adopted in the old GUI. @jasmainak makes a great point that this is a can of worms we probably don't want to open because it is very data-specific. I think we should push users who want to do this sort of analysis to use scripting + the hnn-core API so that they can pull in other signal analysis toolboxes on their own.

gtdang commented 2 months ago

Can I close this issue as "wontfix"?