GUI tonic inputs - Githubissues

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates

https://jonescompneurolab.github.io/hnn-core/

BSD 3-Clause "New" or "Revised" License

54 stars 52 forks source link

GUI tonic inputs #715

Closed gtdang closed 4 months ago

gtdang commented 7 months ago

Ability to set tonic bias parameters

Add a way to interface with .add_tonic_bias method to set Amplitude, start time, and end time for each layer and cell type.

[x] Disable location radio buttons when the Tonic radio is selected
[x] Add tonic accordion with t0 and tstop and cell amplitudes
[x] Information from widgets should populate Network on simulation run

jasmainak commented 6 months ago

@gtdang just wanted to flag that there is already an open PR: https://github.com/jonescompneurolab/hnn-core/pull/635 with discussion. Would be great to take over from there or at least account for the discussion

jasmainak commented 5 months ago

Any updates here? I am running some simulations and would love to play around with this feature using the GUI if it's available ...

gtdang commented 5 months ago

@jasmainak we haven't' started on this issue quite yet. I think a need for an API update was discussed in #635, which will need to be addressed before adding this GUI feature.

kmilo9999 commented 4 months ago

@gtdang @ntolley I want to start working on my own PR instead of continuing #635 . I can take some notes and use some references from that PR in the new one. Let me know your thoughts.

ntolley commented 4 months ago

@kmilo9999 I think it's safe to begin it from scratch, the GUI code has changed quite a lot since then making rebasing a huge pain for this one...