GUI synchronous Inputs - Githubissues

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates

https://jonescompneurolab.github.io/hnn-core/

BSD 3-Clause "New" or "Revised" License

51 stars 50 forks source link

Closed gtdang closed 2 months ago

gtdang commented 5 months ago

Ability to provide exogenous driving inputs synchronously.

jasmainak commented 3 months ago

This is literally just adding a checkbox and setting n_drive_cells = 1?

gtdang commented 3 months ago

This is literally just adding a checkbox and setting n_drive_cells = 1?

I think cell_specific=False also needs to be set from what I see in the ERP Tutorial.

Questions...

Can those values be edited on existing drives? Or should a new drive be added like in that tutorial example?
Should this setting only pertain to evoked drives?
Do we only need one checkbox/toggle for all drives? Or does each drive need its own toggle?

@ntolley @rythorpe

gtdang commented 3 months ago

Discussed with @ntolley.

It would be cleaner to clear the drives and add new drives with the synchronous parameters because of gid ranges.
Should add for all types of drives not just evoked.
Each drive should have its own toggle.