Closed kmilo9999 closed 3 months ago
@ntolley @dylansdaniels
We have noticed that during the plotting of simulation data, the scaling and smooth factors (3000 and 30 respectively) are
automatically applied to the data. Those two default values are also applied to the loaded data (at plotting ) which modifies the value of the data. Also, when comparing the two datasets, both are adjusted by those factors which leads to the inaccuracies in the plot. To address this, we adjusted the initial values of the loaded data to have smooth factor of 0 and scaling factor 1 to preserve the original data values. This is the comparison plot between simulate and loaded data
What is the real purpose of the default smooth and scaling to 30 and 3000 respectively? What do you think about setting the loaded data default values to smooth = 0 and scaling = 1 ?
Attention: Patch coverage is 87.50000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 92.73%. Comparing base (
54ddd40
) to head (118d2af
). Report is 1 commits behind head on master.:exclamation: Current head 118d2af differs from pull request most recent head e83b008. Consider uploading reports for the commit e83b008 to get more accurate results
Files | Patch % | Lines |
---|---|---|
hnn_core/gui/_viz_manager.py | 86.66% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks Camilo!
solves #717