search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
54 stars 52 forks source link

GUI: Clean up dev debug checks #737

Open gtdang opened 6 months ago

gtdang commented 6 months ago

Reminder for CCV to review GUI script and remove any development code used for debugging or TODO references when GUI is ready for release.

To Do

jasmainak commented 3 months ago

I noticed that some loggers have been added to the GUI for debugging purposes:

https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/gui/_logging.py

I'd recommend a different solution. You should use the output widgets the ipywidgets comes with:

https://ipywidgets.readthedocs.io/en/latest/examples/Output%20Widget.html

we have a variable called log_out for that purpose. Unfortunately it's not implemented consistently, so I'd recommend fixing it rather than introduce a new half-baked solution.

We need a repo-wide logger too -- but that's a separate problem. For now, if all the gui code was wrapped into the existing log_out that would be super.

jasmainak commented 3 months ago

Ideally we'd have a repo-wide logger with verbose parameter. And this would be integrated with the jupyter logger using code like this:

https://ipywidgets.readthedocs.io/en/latest/examples/Output%20Widget.html#integrating-output-widgets-with-the-logging-module

cc @ntolley ... ties in with our discussion of verbose parameter for batch processing