search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
51 stars 50 forks source link

[MRG] Added Virtual Environment Directories to `.gitignore` #740

Closed samadpls closed 3 months ago

samadpls commented 3 months ago

Closes #738

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.73%. Comparing base (19aff25) to head (83981a1).

:exclamation: Current head 83981a1 differs from pull request most recent head 0e248a1. Consider uploading reports for the commit 0e248a1 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #740 +/- ## ======================================= Coverage 92.73% 92.73% ======================================= Files 27 27 Lines 4917 4917 ======================================= Hits 4560 4560 Misses 357 357 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jasmainak commented 3 months ago

why does the linkcheck fail @samadpls ?

samadpls commented 3 months ago

why does the linkcheck fail @samadpls ?

It seems like the linkcheck failure started after merging the master branch. I'll investigate further to determine if it's an issue specific to my changes or if other PRs are also encountering this problem.

gtdang commented 3 months ago

(auto_examples/workflows/plot_simulate_beta: line 330) broken https://doi.org/10.1101/2021.04.16.440210 - 403 Client Error: Forbidden for url: https://www.biorxiv.org/lookup/doi/10.1101/2021.04.16.440210

Linkcheck just fails if a URL is inaccessible correct? Seems like this one was down. Link seems to work for me now though. I can rerun the test.

samadpls commented 3 months ago

(auto_examples/workflows/plot_simulate_beta: line 330) broken https://doi.org/10.1101/2021.04.16.440210 - 403 Client Error: Forbidden for url: https://www.biorxiv.org/lookup/doi/10.1101/2021.04.16.440210

Linkcheck just fails if a URL is inaccessible correct? Seems like this one was down. Link seems to work for me now though. I can rerun the test.

Yes… the linkcheck fails if a URL is inaccessible. Thank you for checking and rerunning the workflow. Looks like everything's working fine now that it passed on the rerun.

gtdang commented 3 months ago

Thanks @samadpls!