jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
54 stars 52 forks source link

[MRG] Fix RMSE Annotation #741

Closed kmilo9999 closed 6 months ago

kmilo9999 commented 6 months ago

On this PR we are enhancing the RSME annotation produced when comparing diploes. We stop overwriting annotations from previous runs. We also add a message in the gui console with the information from the last comparison. solves #710

image

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 92.62%. Comparing base (19aff25) to head (c37ae47). Report is 1 commits behind head on master.

:exclamation: Current head c37ae47 differs from pull request most recent head 7b4de47. Consider uploading reports for the commit 7b4de47 to get more accurate results

Files Patch % Lines
hnn_core/gui/_viz_manager.py 0.00% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #741 +/- ## ========================================== - Coverage 92.73% 92.62% -0.12% ========================================== Files 27 27 Lines 4917 4923 +6 ========================================== Hits 4560 4560 - Misses 357 363 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jasmainak commented 6 months ago

perhaps @rythorpe @ntolley can help review ?

gtdang commented 6 months ago

This branch needs a rebase to clear up some of the diffs that there merged from #730.

kmilo9999 commented 6 months ago

@gtdang Rebase done. This PR is ready to review

jasmainak commented 6 months ago

Looks good! Can you squash your commits and add an entry in whats_new.rst so we can give you credit when making the release?