search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
51 stars 50 forks source link

[MRG] Save simulation to csv file #753

Closed kmilo9999 closed 2 months ago

kmilo9999 commented 2 months ago

Added GUI features to export simulation to a csv file solves #718 image

default.txt default.zip

A few things still missing from this PR:

kmilo9999 commented 2 months ago

@kmilo9999 @ntolley This PR is ready to review

I've implemented the zip file approach for downloading simulations with multiple trials. I believe this method is cleaner and aligns with the expected behavior when downloading a set of files. It was also straightforward to implement on the server side. The original solution, which involved downloading files one by one, required additional JavaScript code on the client side.

Additionally, I've added a rule that saves the output as a single CSV file if the simulation only includes one trial.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.78%. Comparing base (d28ddb7) to head (746884c). Report is 39 commits behind head on master.

:exclamation: Current head 746884c differs from pull request most recent head b78b8ba. Consider uploading reports for the commit b78b8ba to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #753 +/- ## ========================================== + Coverage 92.67% 92.78% +0.11% ========================================== Files 27 27 Lines 4928 5018 +90 ========================================== + Hits 4567 4656 +89 - Misses 361 362 +1 ``` | [Flag](https://app.codecov.io/gh/jonescompneurolab/hnn-core/pull/753/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jonescompneurolab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/jonescompneurolab/hnn-core/pull/753/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jonescompneurolab) | `92.78% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jonescompneurolab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kmilo9999 commented 2 months ago

@ntolley @gtdang I rebased the PR to get the checks working. I think this one is ready to be merged.