jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
50 stars 50 forks source link

Coverage not uploading to Codecov #760

Closed gtdang closed 2 months ago

gtdang commented 2 months ago

Unittest actions have been failing since switching to using the codecov-action v4 in https://github.com/jonescompneurolab/hnn-core/pull/758 .

Codecov uploads have sporadically been failing due to rate-limiting of 'tokenless' uploads. It is not actually tokenless, see explanation below.

If Codecov detects that reports are being uploaded from a fork of an open source repository, Codecov will automatically switch to tokenless uploading...Token-less uploads still use a token to upload to Codecov - just that it's Codecov's Github token instead of the project's own. As such, uploading to Codecov via tokenless (whether it's via forks, or by an older version of the Codecov action) ends up consuming from the shared request pool of a lot of Codecov users, instead of your own. Therefore, there may be cases when uploading to Codecov via tokenless fails because Codecov is being rate limited. Source

This issue has been documented by others: https://github.com/codecov/feedback/issues/358 https://github.com/codecov/feedback/issues/301 https://github.com/codecov/feedback/issues/112

I've looked into this problem with #759. I think we will revert back to the bash uploader for now. I'm not sure if it's working properly but at least it doesn't fail the workflow. The bash uploader will be deprecated eventually but they will hopefully update their upload action by then.