[REF]: Refactor network.add_tonic_bias

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates

https://jonescompneurolab.github.io/hnn-core/

BSD 3-Clause "New" or "Revised" License

50 stars 50 forks source link

[REF]: Refactor network.add_tonic_bias #766

Closed kmilo9999 closed 1 month ago

kmilo9999 commented 2 months ago

Refactor network.add_tonic_bias to accept a dictionary of cell types and their amplitudes.
Changed how drivers create tonic inputs
Adjusted unit tests to the new network.add_tonic_bias arguments

jasmainak commented 2 months ago

Don't forget to add tests!

kmilo9999 commented 2 months ago

Don't forget to add tests! @jasmainak I modified the current unit tests that use this function. Should I add more?

kmilo9999 commented 1 month ago

@ntolley @gtdang I applied the last changed. This one is ready to go!

jasmainak commented 1 month ago

made a couple of last-minute comments @kmilo9999 . Sorry I didn't have time to look before but would be great if you could address in next PR. Thanks for your efforts !

ntolley commented 1 month ago

Apologies @jasmainak I was hasty with the merge button! We can definitely address this in the follow up for #715

jasmainak commented 1 month ago

No, you're fine! Please don't wait for my green light to merge.

One more thing to check: was any example updated? Maybe the gamma example uses tonic bias?