search

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
50 stars 50 forks source link

[MRG] Replace `np.in1d()` with `np.isin()` #799

Closed ntolley closed 2 weeks ago

ntolley commented 3 weeks ago

Problem raised in #794 that numpy version 2.0.0 has deprecated np.in1d()

dylansdaniels commented 2 weeks ago

@ntolley i can squash and merge per our discussion yesterday if we're ready to go. seems like a straightforward substitution

rythorpe commented 2 weeks ago

Looks like there might be some flake8 errors, though it looks like don't have anything to do with this PR. Hmmm...

jasmainak commented 2 weeks ago

should you also bump up the minimum numpy version?

ntolley commented 2 weeks ago

@rythorpe fixed the flake8 errors!

Also @jasmainak no need, np.isin() is already a part of numpy v1.14 https://numpy.org/doc/1.14/reference/generated/numpy.isin.html#numpy.isin

gtdang commented 2 weeks ago

@ntolley Seems like all tests passed except the linux. Shall we merge this so @kmilo9999 can continue testing the CI updates?

jasmainak commented 2 weeks ago

Just one tiny comment, otherwise good to merge.

ntolley commented 2 weeks ago

Just one tiny comment, otherwise good to merge.

sounds good! everything should be addressed, whoever seeing the checks (besides ubuntu) go green feel free to merge

jasmainak commented 2 weeks ago

Thanks @ntolley !! 🥳