Record calcium concentration new

jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates

https://jonescompneurolab.github.io/hnn-core/

BSD 3-Clause "New" or "Revised" License

54 stars 52 forks source link

Record calcium concentration new #804

Closed katduecker closed 2 months ago

katduecker commented 3 months ago

Sorry to have opened a new PR, I had some merging conflicts. This one supersedes #792

We decided that the absolute values of the calcium concentration may not be interpretable, which is not a problem, but probably something we want to state in publications that use the feature!

kmilo9999 commented 3 months ago

@katduecker you probably need to rebase this branch in order to run successfully the checklist.

katduecker commented 3 months ago

Thanks!

ntolley commented 3 months ago

Looks like this is the offending line:

Just to double check, does the soma actually have calcium channels? Or should this be changed to one of the dendrites.

katduecker commented 3 months ago

Yep, somehow cell_response.ca was in the wrong line. Thanks for pointing me to it :)

ntolley commented 2 months ago

Great work @katduecker!! We should definitely put together an example showing off how the calcium_model() and the jones_2009_model() differ using this feature.

ntolley commented 2 months ago

Also can you update the title to have the [MRG] tag and get rid of "new"?