jonescompneurolab / hnn-core

Simulation and optimization of neural circuits for MEG/EEG source estimates
https://jonescompneurolab.github.io/hnn-core/
BSD 3-Clause "New" or "Revised" License
53 stars 52 forks source link

[MRG] Remove nulled drives during convert to hierarchical json function #821

Closed gtdang closed 1 month ago

gtdang commented 1 month ago

Updated the hierarchical json conversion script to prune nulled drives. Legacy param files had placeholders for several drives. If unused, values out of typical ranges were specified to null those drives. Typically this occurs when a start time is set greater than the stop time or if weights are set it negatives or 0s. The hierarchical json format will not include drives with bad parameters.

Summary of Changes:

Questions

  1. Are the filters for nulled drives correct/complete?
    • Check for start < stop
    • Checks nmda and amps weights for at least one >0 value
gtdang commented 1 month ago

@ntolley Can you check to make sure the logic I'm using to identify nulled drives is correct? There's a check on the start/stop time. And for the weights, it's checking for at least one positive ampa and nmda weight. Could there be other weight conditions we should exclude or include?