search

jonescompneurolab / hnn

The Human Neocortical Neurosolver (HNN) is a software tool that gives researchers/clinicians the ability to develop/test hypotheses on circuit mechanisms underlying EEG/MEG data.
http://hnn.brown.edu
Other
81 stars 25 forks source link

poisson input causes descrepancy with tutorial #264

Open rythorpe opened 3 years ago

rythorpe commented 3 years ago

During the process of determining if hnn-core outputs the same results over multiple trials as hnn (i.e., as governed by assigning random states), we determined that hnn no longer recreates the same dynamics for Poisson inputs as shown in the gamma tutorial Figure 4.

@jasmainak, @cjayb, and I bisected out 90d992a8c7976d4e819b5ae63609ad5a6bbd7dc3 as the commit that caused hnn to diverge from the results shown currently in the gamma tutorial. This might be a good time to discuss

  1. the "correct" implementation of Poisson inputs (see also the bug fixed in https://github.com/jonescompneurolab/hnn-core/pull/204)
  2. how/when we should update our ground truth representation of Poisson-generated hnn dipoles on the tutorial webpage
jasmainak commented 3 years ago

@stephanie-r-jones @samnemo we need your inputs here

samnemo commented 3 years ago

Can we discuss next week? Any day after Monday works for me.

From: Mainak Jas notifications@github.com Sent: Tuesday, November 24, 2020 6:12 PM To: jonescompneurolab/hnn hnn@noreply.github.com Cc: Neymotin, Samuel (NKI) Samuel.Neymotin@nki.rfmh.org; Mention mention@noreply.github.com Subject: Re: [jonescompneurolab/hnn] poisson input causes descrepancy with tutorial (#264)

ATTENTION: This email came from an external source. Do not open attachments or click on links from unknown senders or unexpected emails.

@stephanie-r-joneshttps://protect2.fireeye.com/v1/url?k=aa9eb443-f5058d21-aa9c4d76-000babd9069e-54d3c10d38334467&q=1&e=d07614c9-b251-4ef8-9888-84bb69902c58&u=https%3A%2F%2Fgithub.com%2Fstephanie-r-jones @samnemohttps://protect2.fireeye.com/v1/url?k=baf9243c-e5621d5e-bafbdd09-000babd9069e-c13af0691d6d419f&q=1&e=d07614c9-b251-4ef8-9888-84bb69902c58&u=https%3A%2F%2Fgithub.com%2Fsamnemo we need your inputs here

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=54593407-0bc20d65-545bcd32-000babd9069e-69b0cf4c935cd908&q=1&e=d07614c9-b251-4ef8-9888-84bb69902c58&u=https%3A%2F%2Fgithub.com%2Fjonescompneurolab%2Fhnn%2Fissues%2F264%23issuecomment-733286202, or unsubscribehttps://protect2.fireeye.com/v1/url?k=9474e6eb-cbefdf89-94761fde-000babd9069e-41cd608e44aed1db&q=1&e=d07614c9-b251-4ef8-9888-84bb69902c58&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACS5H2E63OZF6B7IJRLGUULSRQ4V3ANCNFSM4UBMD3TQ.

IMPORTANT NOTICE: This e-mail is meant only for the use of the intended recipient. It may contain confidential information which is legally privileged or otherwise protected by law. If you received this e-mail in error or from someone who was not authorized to send it to you, you are strictly prohibited from reviewing, using, disseminating, distributing or copying the e-mail. PLEASE NOTIFY US IMMEDIATELY OF THE ERROR BY RETURN E-MAIL AND DELETE THIS MESSAGE FROM YOUR SYSTEM. Thank you for your cooperation.

stephanie-r-jones commented 3 years ago

Can we discuss during our HNN meeting Tuesday morning? Starts at 9:10am.

samnemo commented 3 years ago

Sounds good

From: stephanie-r-jones notifications@github.com Sent: Wednesday, November 25, 2020 9:19 AM To: jonescompneurolab/hnn hnn@noreply.github.com Cc: Neymotin, Samuel (NKI) Samuel.Neymotin@nki.rfmh.org; Mention mention@noreply.github.com Subject: Re: [jonescompneurolab/hnn] poisson input causes descrepancy with tutorial (#264)

ATTENTION: This email came from an external source. Do not open attachments or click on links from unknown senders or unexpected emails.

Can we discuss during our HNN meeting Tuesday morning? Starts at 9:10am.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=3e2af794-61b1ce9a-3e280ea1-0cc47aa88e08-f9ef37635f9c74c1&q=1&e=b0d475ea-9f53-44da-a39e-dcc1e70bc330&u=https%3A%2F%2Fgithub.com%2Fjonescompneurolab%2Fhnn%2Fissues%2F264%23issuecomment-733734602, or unsubscribehttps://protect2.fireeye.com/v1/url?k=be332882-e1a8118c-be31d1b7-0cc47aa88e08-c1af949d34c05c8d&q=1&e=b0d475ea-9f53-44da-a39e-dcc1e70bc330&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACS5H2FUGUASZJHAH7KORRTSRUG5TANCNFSM4UBMD3TQ.

IMPORTANT NOTICE: This e-mail is meant only for the use of the intended recipient. It may contain confidential information which is legally privileged or otherwise protected by law. If you received this e-mail in error or from someone who was not authorized to send it to you, you are strictly prohibited from reviewing, using, disseminating, distributing or copying the e-mail. PLEASE NOTIFY US IMMEDIATELY OF THE ERROR BY RETURN E-MAIL AND DELETE THIS MESSAGE FROM YOUR SYSTEM. Thank you for your cooperation.