search

jonescompneurolab / hnn

The Human Neocortical Neurosolver (HNN) is a software tool that gives researchers/clinicians the ability to develop/test hypotheses on circuit mechanisms underlying EEG/MEG data.
http://hnn.brown.edu
Other
81 stars 25 forks source link

ODict instead of OrderedDict #308

Open mkhalil8 opened 3 years ago

mkhalil8 commented 3 years ago

@salvadord,

Network.py Line 234, specs.OrderedDict gave me an error I changed it to specs.ODict and it ran smoothly. Is that correct?

salvadord commented 3 years ago

Ah sorry, this was an old small bug, the correct code is:

from collections import OrderedDict

... 

output = json.load(fileObj, object_pairs_hook=OrderedDict)

do you mind creating a PR for this? thanks!

mkhalil8 commented 3 years ago

Hi Salvador,

I am trying to make a pull request for the changes, I created a branch from hnn2 named hnn2dev then added the changes above mentioned to a new local repository then:

$ git push origin hnn2dev remote: Permission to jonescompneurolab/hnn.git denied to mkhalil8. fatal: unable to access 'https://github.com/jonescompneurolab/hnn.git/': The requested URL returned error: 403

I tried to push the changes to hnn2 by:

$ git push hnn2 hnn2dev fatal: 'hnn2' does not appear to be a git repository fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

Do I need a permission to push the changes?

salvadord commented 3 years ago

@stephanie-r-jones @blakecaldwell @samnemo @dylansdaniels could you please give access to @mkhalil8 and @claireshort4 so they can contribute to hnn-netpyne (hnn2 branch)? They both attended our meeting today; as you know Mostafa (@mkhalil8) is working with Mohamed Sherif, and Claire (@claireshort4) is working with me. thanks!

samnemo commented 3 years ago

invited as outside collaborators with write access

From: Salvador Dura-Bernal @.> Sent: Tuesday, June 22, 2021 6:43 PM To: jonescompneurolab/hnn @.> Cc: Neymotin, Samuel (NKI) @.>; Mention @.> Subject: Re: [jonescompneurolab/hnn] ODict instead of OrderedDict (#308)

ATTENTION: This email came from an external source. Do not open attachments or click on links from unknown senders or unexpected emails.

@stephanie-r-joneshttps://protect2.fireeye.com/v1/url?k=6c92a63b-33099f35-6c905f0e-0cc47aa88e08-730b3cbb5230227c&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fstephanie-r-jones @blakecaldwellhttps://protect2.fireeye.com/v1/url?k=b5c3dfae-ea58e6a0-b5c1269b-0cc47aa88e08-fac5bef259359411&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fblakecaldwell @samnemohttps://protect2.fireeye.com/v1/url?k=8425e6d9-dbbedfd7-84271fec-0cc47aa88e08-4bf80ac5973599ae&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fsamnemo @dylansdanielshttps://protect2.fireeye.com/v1/url?k=12305fb2-4dab66bc-1232a687-0cc47aa88e08-e7790ec718993fa4&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fdylansdaniels could you please give access to @mkhalil8https://protect2.fireeye.com/v1/url?k=74ebb6b1-2b708fbf-74e94f84-0cc47aa88e08-8df1762afa27ccc6&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fmkhalil8 and @claireshort4https://protect2.fireeye.com/v1/url?k=a965bc1c-f6fe8512-a9674529-0cc47aa88e08-94f2614fd8aafe03&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fclaireshort4 so they can contribute to hnn-netpyne (hnn2 branch) ? thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://protect2.fireeye.com/v1/url?k=092d8ddd-56b6b4d3-092f74e8-0cc47aa88e08-22e4f205122d3d73&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fjonescompneurolab%2Fhnn%2Fissues%2F308%23issuecomment-866384799, or unsubscribehttps://protect2.fireeye.com/v1/url?k=0964fc29-56ffc527-0966051c-0cc47aa88e08-fb63638cb1800cf2&q=1&e=9d0b9050-432a-41d1-ac5c-3a18e7e65b87&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACS5H2CHGDNLRVKDOV7G23TTUEGXJANCNFSM46W7NGPQ.

IMPORTANT NOTICE: This e-mail is meant only for the use of the intended recipient. It may contain confidential information which is legally privileged or otherwise protected by law. If you received this e-mail in error or from someone who was not authorized to send it to you, you are strictly prohibited from reviewing, using, disseminating, distributing or copying the e-mail. PLEASE NOTIFY US IMMEDIATELY OF THE ERROR BY RETURN E-MAIL AND DELETE THIS MESSAGE FROM YOUR SYSTEM. Thank you for your cooperation.