search

jonescompneurolab / hnn

The Human Neocortical Neurosolver (HNN) is a software tool that gives researchers/clinicians the ability to develop/test hypotheses on circuit mechanisms underlying EEG/MEG data.
http://hnn.brown.edu
Other
80 stars 25 forks source link

Version issue with windows native install powershell script #318

Open neuroptics opened 2 years ago

neuroptics commented 2 years ago

Just perusing, not worried about performance at the moment and not wanting to mess with WSL....

In https://raw.githubusercontent.com/jonescompneurolab/hnn/master/installer/windows/hnn-windows.ps1

Line 365: "Rename-Item .\hnn-1.3.1 .\hnn"

Throws an error with newer versions (currently 1.3.2).

Should be an easy fix, thanks!

ntolley commented 2 years ago

@neuroptics thanks for raising the issue! Unfortunately I don't have a windows build to test this out, is this where the error is raised or did you manually edit the script yourself?

@jasmainak @rythorpe do you have a windows build to test if this install runs properly through powershell?

jasmainak commented 2 years ago

unfortunately I don't, if @neuroptics makes a pull request after testing it out, I'm happy to merge it though

rythorpe commented 2 years ago

I don't either. If we need to though, I can dust off my dual boot windows/ubuntu machine and try for a clean native install on windows 10.

neuroptics commented 2 years ago

Thanks everyone! I can confirm that changing the 1 to a 2 works.

I have zero experience with powershell but it looks like the permanent fix should be: Rename-Item .\hnn-* .\hnn

I'll test it on one of our other machines when I get a chance unless someone else beats me to it.