jonesguy14 / footballcoach

Android App for playing/simulating/recruiting as a college football coach
Other
34 stars 8 forks source link

Reverted mistakes and uncommented TOD game log. #32

Closed destilla closed 8 years ago

destilla commented 8 years ago

Per comments in the last pull request, reverted my derp mistakes to be how they should:

Yards gained on a breakaway TD is taken care off in the next lines of code so I changed that back to yardsGain += 100

and

I have no idea why I originally removed gameDown++ from the qbSack function; --- I think my brain wanted to advance it after the time was decremented or something, as if real football was happening, but even that is a silly explanation. It's been added back in.

Also uncommented the game log of a turnover on downs (the format for which I basically took from a combination of the onside kick formatting and the other turnover formattings)

jonesguy14 commented 8 years ago

Looks good. Development on my end has slowed down a bit (have some assignments this week that I've been putting off) so having another person add things and fix stuff is pretty nice!

Let me know if you find anything else. If you are wanting a challenge you could look at the issue list (in particular people have been asking for college OT rules).

Also, since you know a bit about the game and what is being added/changed, I could make you a mod over at /r/FootballCoach if that's something you are interested in.

destilla commented 8 years ago

Haha sorry I made a comment on the other Pull Request; I'm still figuring out proper GitHub posting etiquette and what not.

I would love to try to tackle OT rules; I feel like that's within my abilities to figure out and not mangle the rest of the functionality. I was actually going to throw something together as a fun "can I do this" experiment, so your suggestion is well timed. f I get some free time tomorrow I'll take a look at it.

And sure absolutely, I'd love to be a mod! I like answering questions and the community is fun to participate with.