jonesguy14
commented
8 years ago Love the news stories but just a couple things:
- findTeam(..) was actually like that on purpose, its used when finding teams via the team spinner in the MainActivity, and since the spinner holds the strRep of teams (like #5 WAS (11-3)) instead of their full name I made findTeam(..) use the strRep() instead. I guess it is a bit ambiguous though. So if you are using findTeam(..) like you want to find a team just based on name, I guess just make it a separate function like findTeamName(..) or something. Sorry about that, I should've been more clear in my comments in the code.
- Also looks like you got rid of the activeWinStreakStr from the getLeagueRecordsStr(). Probably just a version control thing where you might've had slightly old version of the code.
But other than those two things looks good to go. I love the news stories, people on the subreddit got pretty creative!
destilla
Added Week 0 stories using method you suggested last night (keeping team name in a string, building an object from that). These are the same stories from last night with some minor grammatical and spelling corrections. Also cleaned up variables I added while experimenting with the best way to handle the new stories.
Made a minor bug fix to findTeam() that I discovered while using it to build the new team object (findTeam() was checking that the passed argument matched strRep() instead of team name)