search

jonesguy14 / footballcoach

Android App for playing/simulating/recruiting as a college football coach
Other
34 stars 8 forks source link

Improved Locker Room Fight Story, Added New Week 0 Bless Story #64

Closed destilla closed 8 years ago

destilla commented 8 years ago

Added/improved follow up stories for the locker room fight curse story -- The follow up stories now check for more scenarios such as did the QB have a bad game in a loss, did the QB have a good game in a loss, was the QB average, etc. and prints an appropriate story to match. I feel better about this as it felt incomplete last night but I wanted to get something posted.

Also added a new bless story for week 0. This was originally pitched as a story about the team partying hard before homecoming and losing, but still getting positive attention from recruits who wanted to live that party life. Instead of trying to make a complex setup where the schedule was checked for a random game and have that game be a loss etcetcetc, I just made a week 0 story about big parties happening at/after fall practices and how this was getting positive attention from recruits.

Smaller changes: Changed the dance off story headline, fixed how cursedQB's completion percentage was being calculated to be based on how you did it for the QB stats page (it wasn't calculating correctly before)

At this point I probably have about 2 or 3 stories left before I can consider this complete and move on to something else (probably restructuring runPlay() to have more complete clock management scenarios)

destilla commented 8 years ago

Some of these stories remind me of why I didn't go into a language arts field: I can write a decent story, but the longer I have to go the lamer it sounds, haha

jonesguy14 commented 8 years ago

Looks great! Also I have no idea why I didn't use Math.max() for more stuff, those places where I was worried about a divide by zero error would've been much cleaner.

destilla commented 8 years ago

Thanks! I basically copied your way of handling comp percentage, so thank you for including that or I would have been stuck forever, haha. The Java.max thing was me thinking back to my time in excel and figuring that java had to have something similar.

Lo and behold, I found Java.max. On Apr 12, 2016 2:46 PM, "Joachim (Achi) Jones" notifications@github.com wrote:

Looks great! Also I have no idea why I didn't use Math.max() for more stuff, those places where I was worried about a divide by zero error would've been much cleaner.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/jonesguy14/footballcoach/pull/64#issuecomment-209116321