jonesguy14 / footballcoach

Android App for playing/simulating/recruiting as a college football coach
Other
34 stars 8 forks source link

Fixed Safeties Being Reported on the Wrong Down #72

Closed destilla closed 8 years ago

destilla commented 8 years ago

When a safety occurred, the down would advance before getEventPrefix() was called, which resulted in the safety being reported on the down after it actually happened.

This mean that a safety that occurred on third down would report "4th and X on the Y yardline -- Safety!" which really wouldn't make sense from a play selection standpoint, and would literally be impossible with the game logic as it exists now (unless the team was down by enough to warrant going for it late)

Also removed the section of convGameTime() that handled the old OT format (13:25 OT1) as we don't use that OT anymore.

destilla commented 8 years ago

No idea why it's showing every single merge request I've done from the main repo as something to merge here, but I changed like, 8 lines of code total.'

Also I could swear I saw a game log recently that reported a play happening at 15:00 of Q5, but I didn't screenshot it and I can't find any way that this would be possible.

jonesguy14 commented 8 years ago

Good catch, thanks! And yeah not sure whats up with all the merge requests but its nbd.