joneshf / terraform-provider-openwrt

A Terraform provider for OpenWrt using LuCI's JSON-RPC API
https://registry.terraform.io/providers/joneshf/openwrt
Mozilla Public License 2.0
33 stars 8 forks source link

Fix UCI type for `wireless.wifi-device` #124

Closed joneshf closed 1 year ago

joneshf commented 1 year ago

This typo is everything that's wrong with UCI. There's no consistency in the naming scheme. And, there's nothing stopping you from using the incorrect UCI type. Nothing failed for any of the tests here because at its core, UCI allows basically any config to have any name with any section with any options. It's way too lenient, and it means that you have to be extra careful whenever you're using it directly (like we're doing here).

If there's a way to accurately test that we're using the correct thing, we should switch to it. But, it's not clear how we'd actually catch a mistake like this.

In any case, we fix this typo, so a wireless.wifi-device can actually be created now.