pawaitemadisoncollege
commented
2 years ago Hi @jonesna213! Your project is in really good shape - ahead of the minimum that I would expect for this point in the semester! Following are my comments/observations in review things for Checkpoint 2.
Database designed and created
- This looks to be well-designed and meets or exceeds the number of tables and relationships an enterprise java project should have.
At least one DAO with full CRUD (create, read, update, delete) implemented with Hibernate and fully unit tested
- I noticed your comment about stack overflow errors with hibernate and unit testing. That type of error is often caused by circular references between entities in toString, equals, and hashcode methods. I'll use the author/book entities as an example: if author.toString calls the book.toString and the book.toString calls the author.toString, etc., we could end up in an endless loop ending with a stack overflow. The solution may be to stop the loop by removing one of the calls on one entity. I think you've resolved this already and likely already determined the cause in that process, but just wanted to be sure in case it happens again! -[ ] Unit testing could be improved by further testing the delete scenarios. If a user is deleted, what happens to their parts? What if a merchant is deleted? Use tests to verify what should happen does happen. These are also great for identifying if/when future changes break things!
Log4J is implemented (no System.out.printlns)
- [ ] There is one sneaky print statement here: https://github.com/jonesna213/IndividualProject/blob/4436e57f16ae3324354b22bb46ef84b73ca81c06/src/main/java/com/hondaparts/util/RockAuto.java#L82-L83. Can this be logged instead?
Other
Your plan to limit how far you take the JSoup makes sense - if you implement a couple different parts and/or sites, that will demonstrates your skill and would be appropriate for a first version of this project this semester.
- [ ] I know you have work todo on the JSoup classes yet, but just a reminder to be careful with this path when deploying to aws.
Regarding your question about editing or deleting the user. There are methods available in the Cognito api to do this, however if you have full crud on the db, you do not have to worry about Cognito unless you want to. Depending on how you are doing with other functionality, you could hold on that for an eventual V2 or make it a stretch goal for V1.
Keep up the great work! Looking forward to Checkpoint 3!!!!
@pawaitemadisoncollege Checkpoint 2 is ready for review.
Its not as far along as I would have liked (been a little busy with other classes/personal stuff). But its definitely made progress and I'm starting to understand how to put it all together. JSoup is definitely going to be the big struggle (implementing for getting tons of different parts and from different websites. As of now I want to get it working for one type of part on two different websites just so the concept is there, then add other parts after that). Getting the relationships for the database setup correctly with hibernate seems like its also going to be a bit tedious, but it will happen. I also just have the JSoup stuff setup in a main method for now as I'm still working on figuring it out but eventually I want to add a button on the website for an admin user to be able to click to update the database with parts.
I do believe I hit all the requirements for checkpoint 2 though since I have the user table all implemented with cognito and fully unit tested (not including the other tables though). Only thing that I can tell is deleting and updating for the user, I'm not sure if cognito offers this though.