jonge-democraten / website

JD website
https://jongedemocraten.nl
MIT License
6 stars 2 forks source link

On new website, when menu bar is too long, it is shoved out of the white space reserved for it #196

Closed Pi2048 closed 6 years ago

Pi2048 commented 6 years ago

Steps to reproduce:

At certain zoom levels, the text in the menu bar is shoved downward when it doesn't fit anymore into the space allotted to it.

This happens both on Firefox and Chromium.

bartromgens commented 6 years ago

Good find!

This also happens without zooming when the menu is simply too long due to too many/long pages. It is currently working as intended (not an implementation bug), but not the desired behaviour.

This is a common problem with the bootstrap navbar (menu). If the menu width is fixed, this can be managed by hiding certain menu items depending on the screen-size (hard-coded), reducing font size, or collapsing into the menu into the hamburger (mobile) menu.

Our menu width is not fixed; the menu is defined in the admin. The website template is designed with a fixed width in mind. If the menu is within this max width, there is no problem, also not with zooming.

The real question is what behaviour we want here, some options I can think of:

Something to discuss.

mathemaat commented 6 years ago

It appears this is no longer an issue, and we've forgotten to close the issue. If I keep zooming, then at some point the horizontal menu is replaced by a button that opens the menu vertically.