jonge-democraten / website

JD website
https://jongedemocraten.nl
MIT License
6 stars 2 forks source link

Escaping email addresses using Javascript #49

Closed Pi2048 closed 9 years ago

Pi2048 commented 9 years ago

I have chosen this approach based on the discussion on https://stackoverflow.com/questions/748780/best-way-to-obfuscate-an-e-mail-address-on-a-website, but I welcome other views. There, people argue that spam filtering works better than e-mail address hiding, and I'm inclined to agree with them. This approach will stop the basic attacks, and spam filters will hopefully work against the more sophisticated ones.

I explicitly would like to hear people's views before I merge my solution to master.

bartromgens commented 9 years ago

I also agree that we should mainly rely on spam filters. It's simply not possible to fully hide email addresses for crawlers in a user friendly way. I believe many of the public jd email addresses are already out in the open so we need good spam filters anyway.

The obfuscation you added in commit cb3bd219b7ed6c97d67293d5bccd89dd8ec18569 is a good first line of defence.

Pi2048 commented 9 years ago

@bartromgens, thanks for giving your view.

Merged the branch for now. I'll leave it to Bas to evaluate the functionality. To me, this issue is closed for now.

secretarisjongedemocraten commented 9 years ago

Agree with the discussion in https://stackoverflow.com/questions/748780/best-way-to-obfuscate-an-e-mail-address-on-a-website. When using spamfilters there is a good protection and a userfriendly way, so according to me a good option.