search

jonge-democraten / website

JD website
https://jongedemocraten.nl
MIT License
6 stars 2 forks source link

Document Listing should give visual feedback when adding files #64

Closed m-lies closed 9 years ago

m-lies commented 9 years ago

Been trying to upload documents in 'Add Document Listing', the documents are not shown when I click on 'select'. Disabled AdBlockerPlus and tried in Firefox and Chrome. Basically, nothing happens. Furthermore, there is an option to add another field to upload an extra document. However, it is not possible to delete a field if it remains empty. You seem to be only able to delete a field if there is already a document uploaded.

Pi2048 commented 9 years ago

Both these issues stem from the same problem: Document Listings do not give visual feedback when you've added a file. I'll look into this.

Pi2048 commented 9 years ago

I was not able to change this behaviour without changing the Mezzanine/Filebrowser-safe code. I will send an e-mail on this subject to the mezzanine-users mailing list.

Pi2048 commented 9 years ago

We got a reply: https://groups.google.com/forum/#!topic/mezzanine-users/cmcu39K8K8U.

It appears this was actually a bug in filebrowser-safe. They fixed it now. This means the latest version of filebrowser-safe will not have this problem.

A ./clean_env.sh, followed by a ./build_env.sh should fix this for gallery photos. Next is thumbnails in document_listings.

Pi2048 commented 9 years ago

I tested it and it works. In document_listings, you will now see a broken thumbnail with a link to the selected document. I will find some image to use as default thumbnail for documents.

bartromgens commented 9 years ago

Again good to hear this is fixed so quickly.

Also good job on reporting this issue Pieter. As developer, I like users who report issues. Most are simply too lazy. Others think it is some kind of negative feedback that is rude. They say things like 'sorry, but this does not work'. Any good developer welcomes bug reports. It's a compliment that someone uses your work and wants to make it better.

Pi2048 commented 9 years ago

The aforementioned commit should resolve this issue. When a user now selects a document, the help text 'Document selected' is displayed.