search

jongough / ocpn_draw_pi

OpenCPN general drawing plug in
8 stars 18 forks source link

add to odapi to turn off squiddio text #489

Closed rgleason closed 3 years ago

rgleason commented 3 years ago

Mauro had a good idea to fix the show text issue that is inconsistent as compared to the way show text worka using Opencpn waypoints. Add to odapi to turn on of Show text.

That way we dont need to wait for a change in pi api.

@jongough @mauroc

jongough commented 3 years ago

I am not sure what issue you are referring too regarding show text. When you select to use use ODraw Text Points you select when you want the text to be displayed, always, on rollover, never. The never option is equivalent to the OCPN Waypoint display. If you don't want the Text Point name to show, then just deselect that in the properties and it does not show. If you zoom in and out the test, if displayed will continue to do so until it becomes over powering and then it disappears.

mauroc commented 3 years ago

sorry there must have been miscommunication between me and Rick. The change I was thinking about was actually in the OCPN pi apis for classic waypoints. The Draw text hide/view feature already works fine in my mind

jongough commented 3 years ago

Thanks for the letting me know, I was worried I had missed something.

rgleason commented 3 years ago

It is the show text text box that shows all the black poi titles.Also it might br good to have them be scale sensitive before they turn on at a scale that can be read.On Oct 13, 2021 5:33 PM, jongough @.***> wrote: I am not sure what issue you are referring too regarding show text. When you select to use use ODraw Text Points you select when you want the text to be displayed, always, on rollover, never. The never option is equivalent to the OCPN Waypoint display.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

jongough commented 3 years ago

If you do not want the Text Point Name to show that is settable in the Squiddio preferences. Then the icon only will show, and if you have set the text to show on rollover, does that not satisfy the needed. I have tried a waypoint and given it a name to show and that name shows at all zoom levels. The text does not change size.

rgleason commented 3 years ago

Sorry, i had gotten tbis. Wrong. We need tk make an api request to dave Can one of you give use the techical description?

mauroc commented 3 years ago

I can take a stab at it, perhaps by posting a PR directly to OCPN

rgleason commented 3 years ago

That would be great Mauro!

mauroc commented 3 years ago

this brings up another question: have there ever been any discussions of making Odraw an integral part of OpenCPN rather than a plugin? In a self-serving way, squiddio works so much better with it than with OCPN waypoints, but I can't make this the default config as it depends on Odraw being installed. ...just wondering.

jongough commented 3 years ago

OD started by adding the functionality to OCPN, however, Dave requested that I removed it (wouldn't accept the pull) and create a separate plugin. I think there is enough capability in OD for it to take on Routes and Waypoints as well if needed, so it could be made part of OCPN (a rework of some of the code would/may be needed) and it would be more extensible than the current OCPN Route and Waypoint code. However....

rgleason commented 3 years ago

I guess this should be closed