search

jongough / ocpn_draw_pi

OpenCPN general drawing plug in
7 stars 17 forks source link

1.8.20 Icon Sizes and Testing #517

Closed rgleason closed 1 year ago

rgleason commented 1 year ago

I won't comment much. Just show you what the problems are. 1-draw 2-draw 3-draw

rgleason commented 1 year ago

4-draw 5-draw 6-draw

rgleason commented 1 year ago

7-draw 8-draw 9-draw 10-draw

rgleason commented 1 year ago

11-draw 12-draw 13-draw 14-draw

rgleason commented 1 year ago

15-draw

rgleason commented 1 year ago

Have tried 1.8.20 version and it has the same problems. Sorry.

jongough commented 1 year ago

The current beta version is 1.8.21.0, can you try that please.

rgleason commented 1 year ago

Thanks! Jon

Yes, downloaded it from Cloudsmith. Ran into some issues. I hope these screenshots help. If not I can run it again and grab what you need. Screenshot (1030)

Screenshot (1031)

Screenshot (1032)

Screenshot (1033)

rgleason commented 1 year ago

Is it missing the symbols?

    ocpn_draw_pi.dll!5c137aa6() Unknown
    [Frames below may be incorrect and/or missing, no symbols loaded for ocpn_draw_pi.dll]  
>   opencpn.exe!PluginLoader::LoadPluginCandidate(wxString file_name, bool load_enabled) Line 366   C++
    [External Code]
jongough commented 1 year ago

I have just tried it by loading OD from the beta repository via plugin manager using OD 5.7.1 and it works fine. The error you are seeing comes from OCPN not OD. It is plugin manger looking for a plugin and having issues. Can you look at the opencpn.log and see what it says about loading plugins.

rgleason commented 1 year ago

Are you sure you don't have the symbols on your computer?

    ocpn_draw_pi.dll!5c0c7aa6() Unknown
    [Frames below may be incorrect and/or missing, no symbols loaded for ocpn_draw_pi.dll]  
>   opencpn.exe!PluginLoader::LoadPluginCandidate(wxString file_name, bool load_enabled) Line 366   C++
    [External Code]

I was using visual studio. I will download the new Beta #4 and try it.

rgleason commented 1 year ago

It seems to be working better with Beta #3 after deleting ocpn_draw.dll 2-3 times while bombing out. I think it was ocpn-draw 1.8.20 that was bombing.

This is much better, the icons could be a little smaller to match the toolbar.

ocpn_draw

jongough commented 1 year ago

You should be able to scale the icons, over a reboot, using OD settings/General/Icon Scaling.

I may change that to say 'Toolbar icon scaling' to make it clearer.

jongough commented 1 year ago

The entry on the General tab is "Toolbar icon scaling (requires restart)"

rgleason commented 1 year ago

This is working now. Thanks Jon. Very welcome improvement