CI Questions

[rgleason]

Submodule OpenCPN/opencpn-libs For commands see the Instructions at the bottom.

DONE

• Local and CI tarballs include metadata.xml - Done

• 366 Yes Done

• 355 Yes. Done

• 364 Done.

• #3223 Yes Done

• 365 Some discussion about packaging for plugins.

• 368 ? Yes. v5.10 Done

• Drop OpenCPN 5.6.2 builds when v5.10 comes out. See template table - Done
• Drop Buster and Bionic Builds - When v5.10 comes out. (these are used for O5.6.2) -Done
• Upgrade to API 118 for OpenCPN 5.10 Not tet neccessarily.

NO NEED TO DO YET

• Support plugins maintained by package managers
• Update to wxWidgets 3.2.2 - Dave says no need to until v5.10
• Move from API 117 to API118 with v5.10 not necessary, but desireable See Jon's directions for moving to 118

[rgleason]

5.10 is here, should we be doing these?

• Update to wxWidgets 3.2.2 - Dave says no need to until v5.10
• Upgrade to API 118 for OpenCPN 5.10
  • Change 1.17 to 1.18 in CMakeLists.txt
  • Change 117 to 118 in [plugin_pi.cpp] around line 91
• Move from API 117 to API118 with v5.10 not necessary, but desireable Give us improved version numbering. Need to change some code in each plugin.

[jongough]

Upgrading testplugin to 118 in version 1.0.308.0. This will require two changes in the CMakeLists.txt file

• Change the line set(OCPN_API_VERSION_MINOR "17") to set(OCPN_API_VERSION_MINOR "18")
• Change the line add_subdirectory(opencpn-libs/api-17) to add_subdirectory(opencpn-libs/api-18)

Then the main cpp file will need to be based on 118 change

testplugin_pi::testplugin_pi(void *ppimgr)
:opencpn_plugin_117(ppimgr)

to

testplugin_pi::testplugin_pi(void *ppimgr)
:opencpn_plugin_118(ppimgr)

and in the header file change class testplugin_pi : public opencpn_plugin_117 to `class testplugin_pi : public opencpn_plugin_118'

These should reflect the plugin name not testplugin.

[rgleason]

That is a great help, Thank you Jon. I missed a couple of things (got the first and third changes). What/where is the "header" file with the "class"

[jongough]

The plugin header, in FE2's case - testplugin_pi.h, so just look in the requisite header file for the plugin where it defines the plugin class.

[rgleason]

Thanks, found it here in your commits . I am rusty! https://github.com/jongough/testplugin_pi/pull/403/commits/0f0db24b73afb5448d5d695e3bd2c38c1c6c8fc8