Adding Template Table for 5.10.2 - Correct?

[rgleason]

Jon, Can you please take a careful look at the 5.10.2 Table at the top https://github.com/jongough/testplugin_pi/issues/284 Is it correct now and reflect what we are building now?

Also I wonder about some of the config.yml code that we have now.

These are frozen and not being built (commented out) Start at Line 65 https://github.com/jongough/testplugin_pi/blob/master/.circleci/config.yml#L64

 ## -------------------------------------------
 ## OpenCPN 5.6.2 Plugins  Frozen - 28/05/2023
 ## ------------------------------------------
 ## Circleci will not build for macos 11 so removed - 18/10/2023
         - build-macos:
              <<: *std-filters
         - build-msvc-2022:
             <<: *std-filters

 ## -------------------------------------
 ## UBUNTU OS  Frozen - 28/05/2023  DROP
 ## -------------------------------------
 ## KEEP needed for Raspbian OpenCPN v5.6
 #        - build-ubuntu-armhf-1804-buster:
 #            <<: *std-filters

Starting at Line 410 we have, should these be commented out just as above because they are not being built?

 ## ---------------------
 ## OpenCPN 5.6.2 Plugins
 ## ---------------------
     build-macos:
         macos:
             xcode: "13.4"
         environment:
         - OCPN_TARGET:  macos
         - CLOUDSMITH_PKG_EXT: pkg
         - WX_VER: 315
         - DEPLOY_USE_ORB: false
         steps:
         - checkout
         - run: chmod a+x ci/*.sh
         - run: bash ci/circleci-build-macos.sh
         - deploy-code:
             deploy_use_orb: false

 ## Appveyor doesn't build for Windows now.
 ## If below is used, WinXT will not work.
     build-msvc-2022:
         executor:
             name: win/server-2022
             shell: cmd.exe
         environment:
         - OCPN_TARGET: MSVC
         - MSVC_VERSION: 2022
         - WX_VER: 31
         - DEPLOY_USE_ORB: false
         steps:
         - checkout
         - run:
             privileged: False
             shell: cmd.exe
             command: ci\circleci-build-msvc.bat
         - deploy-code:
             deploy_use_orb: false

On Line 388 - We are still building this - Correct?

## KEEP needed for OpenCPN v5.8 Jammy wx32 build
    build-ubuntu-x86_64-2204-jammy:

Are there any other changes needed?

[jongough]

The current, 1.0.309.0, testplugin config.yml has been cleaned up and the macos xcode moved up to 14.2. To keep things consistent there is still a build of macos with wxWidgets 3.1.5 for use in OpenCPN5.6.2. The build process does not make explicit use of 5.10.2 or above, but will work with them. The version of the OCPN API in testplugin has been increased to 118 from 117 as there appears to be an issue with the "tweak" number and the use of the catalog version rather than the xml version when displaying plugins in the installer.

I believe all the changes needed have been made to 309 of testplugin.

[rgleason]

My takeaways from Jon are Testplugin 1.0.309 changes:

1. Still building O5.6.2 Windows msvc version as above
2. Still building O5.6.2 MacOS build with wxWidgets 3.1.5 as above
3. Still building O5.8 Jammy wx32 as above
4. MacOS builds are using xcode 14.2 now
5. OpenCPN 5.10.2 runs 5.8 plugins nicely
6. Testplugin API 118 to fix issue with the "tweak" number and the use of the catalog version rather than the xml version when displaying plugins in the installer.

[rgleason]

I see a note in the Template Table under OpenCPN 5.6.2 Plugins https://github.com/jongough/testplugin_pi/issues/284 Plugins using API 118 do not build these plugins.

So how does changing to API 118 affect building O5.6.2 plugins? Is this automatically taken care of? Or do we need to use an API-118-config.yml such as I have here (I am not sure this is exactly correct, but I used it for douwe's autopilotraymarine plugin.) https://github.com/rgleason/testplugin_pi/blob/master/.circleci/config-API118.yml

[jongough]

I don't think API-18 is available in OCPN 5.6.2, it is too new as it was updated on 1st Dec 22 and 5.6.2 was released on 22nd April 22.

[rgleason]

Yes, so since CMakeLists and config.yml don't have an option to pick 118 or 117, I think the answer is that we cannot build for 5.6.2 anymore.

[jongough]

When plugins are updated to 118, no they cannot. Not sure why we keep getting these breaking changes as not everyone has the latest and greatest toy. From my plugin perspective I don't need anything from 118 that is not supplied by 117. It would appear to be a plugin manager problem and should have been isolated to that alone rather than all the plugins.

[rgleason]

I wrote Dave about the API 118, and he wrote back that we should just keep using 117 if we don't need 118 (IE: nmea2000 signalk, etc).

Perhaps we should just stick with 117. I just got weatherfax working with 118 but it is missing macos and is a couple of builds short.

What do you think we should do?

[jongough]

Go with what Dave says, stick with 117 until we are forced to move. The issue with plugin manager not showing the 'tweak' level has been around for quite some time and the error of it using the 'catalog' rather than the installed version is another error with the plugin manager that is not related to the API version.

The changes in FE2 are located in the CMakeLists.txt file and the plugin main cpp and h files, so it shouldn't be too difficult to update or revert. I will take testplugin back to 117 and leave it there until we are required to update.

[rgleason]

Great, I think that's the best thing to do too. Thanks. Sorry about that.