jongpie / NebulaLogger

The most robust observability solution for Salesforce experts. Built 100% natively on the platform, and designed to work seamlessly with Apex, Lightning Components, Flow, Process Builder & integrations.
https://nebulalogger.com
MIT License
709 stars 165 forks source link

Bugfix: overzealous data masking rule for US social security numbers #751

Closed jongpie closed 2 months ago

jongpie commented 3 months ago

Core Unlocked Package Changes

🐞 Fixed #542 (almost exactly 1 year after it was opened😅) to use a more targeted regular expression for identifying US social security numbers (SSN) to mask. Previously, the rule was not restrictive enough in the regular expression used in SensitiveDataRegEx__c, which resulted in the rule masking some values that it should have ignored.

For example, logging a message containing a (fake) credit card number like Here is a value 5000-1111-2222-0005 and it looks like a Mastercard number, so apply the Mastercard masking rule...

🤏 And a little bit of scope creep included:

Pipeline Changes

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.16%. Comparing base (2894401) to head (6d7d04a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## ======================================= Coverage 93.16% 93.16% ======================================= Files 67 67 Lines 6950 6953 +3 Branches 199 199 ======================================= + Hits 6475 6478 +3 Misses 447 447 Partials 28 28 ``` | [Flag](https://app.codecov.io/gh/jongpie/NebulaLogger/pull/751/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Gillespie) | Coverage Δ | | |---|---|---| | [Apex](https://app.codecov.io/gh/jongpie/NebulaLogger/pull/751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Gillespie) | `95.46% <100.00%> (+<0.01%)` | :arrow_up: | | [LWC](https://app.codecov.io/gh/jongpie/NebulaLogger/pull/751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Gillespie) | `83.26% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Gillespie#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.