jonhadfield / python-hosts

a hosts file manager library written in python

MIT License

125 stars 33 forks source link

feat: inline comments #36

Closed lucasfcnunes closed 2 years ago

lucasfcnunes commented 3 years ago

Answers https://github.com/jonhadfield/python-hosts/issues/20 Retries https://github.com/jonhadfield/python-hosts/pull/10

Sorry ;) https://github.com/jonhadfield/python-hosts/pull/35#issuecomment-860255683

coveralls commented 3 years ago

Coverage remained the same at 0.0% when pulling 3e5016af73faa0532899d2203944f07da24ffecd on lucasfcnunes:devel-inline-comments into f9210dda91d2991435d06635760932cb63357df1 on jonhadfield:devel.

coveralls commented 3 years ago

Coverage remained the same at 0.0% when pulling 17c0c72d078d12fcead34f3645fdf7ae699555e2 on lucasfcnunes:devel-inline-comments into f9210dda91d2991435d06635760932cb63357df1 on jonhadfield:devel.

lucasfcnunes commented 3 years ago

making more changes to this. now i'm running the actual tests and making some too haha

codecov-commenter commented 3 years ago

Codecov Report

Merging #36 (17c0c72) into devel (f9210dd) will decrease coverage by 0.59%. The diff coverage is 90.47%.

:exclamation: Current head 17c0c72 differs from pull request most recent head 16ec963. Consider uploading reports for the commit 16ec963 to get more accurate results

@@             Coverage Diff             @@
##             devel      #36      +/-   ##
===========================================
- Coverage   100.00%   99.40%   -0.60%     
===========================================
  Files            4        4              
  Lines          321      336      +15     
===========================================
+ Hits           321      334      +13     
- Misses           0        2       +2

Impacted Files	Coverage Δ
python_hosts/hosts.py	`99.30% <90.47%> (-0.70%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9210dd...16ec963. Read the comment docs.

lucasfcnunes commented 3 years ago

@jonhadfield, any thoughts on this?

github-actions[bot] commented 3 years ago

Stale pull request message

jonhadfield commented 3 years ago

Sorry it got closed. I'll take a look asap.

sebalis commented 2 years ago

Hi @jonhadfield, the PR seems to have been automatically closed a second time before you got to merge it. Could you reopen and merge? I’m intertested in using this feature, and also I’d consider it important to add coverage for this part of the hosts file format. I was able to merge it in a clone (on my local system, not on Github) without conflicts and all tests succeeded. Thanks :-)

sebalis commented 2 years ago

Oh, and while you’re at it, Id suggest editing the commits to remove the misspelling of the past participle of “split” that was introduced by @lucasfcnunes – which should of course (and confusingly) be “split” but was coded as “splited”.