search

jonhadfield / python-hosts

a hosts file manager library written in python
MIT License
125 stars 33 forks source link

1.0.4 breaking change hosts_path -> path #48

Closed mattrussell-sonocent closed 4 months ago

mattrussell-sonocent commented 1 year ago

We had some code that uses python-hosts break on update to 1.0.4 because Hosts.hosts_path was renamed to path in https://github.com/jonhadfield/python-hosts/commit/fa0e8608e132fbf82b4c4184f01eb6d92720966d. Easy to fix once you know about it, but would it be worth adding hosts_path back for backwards compatibility?

jonhadfield commented 1 year ago

Sorry about that. I should have incremented the minor version, rather than the patch, and made a note.
Do you mean to revert the change, or also include hosts_path and somehow handle both? My issue with the latter is it would make it confusing wrt. setting, getting, and reprs, etc.