Fix remove_all_matching

jonhadfield / python-hosts

a hosts file manager library written in python

MIT License

125 stars 33 forks source link

Fix remove_all_matching #6

Closed dmtucker closed 8 years ago

dmtucker commented 8 years ago

Resolves #5

coveralls commented 8 years ago

Coverage decreased (-0.4%) to 99.275% when pulling 97de2c3a527d582cdfdeff8e431b165889a8769d on dmtucker:devel into c1403cc8beac2a9142a21c2de555eb9e5e090f9b on jonhadfield:devel.

dmtucker commented 8 years ago

The failing test passes on my system (Debian 8.5, tox 2.3.1):

tests/test_hosts.py::test_exception_raised_when_unable_to_write_hosts PASSED

It also passes with Travis... so this is strange. Perhaps it is a problem with the tests?

jonhadfield commented 8 years ago

I don't actually remember configuring for Shippable testing - so more than likely a test failure than a code issue. Will have a look when I get some time this week. Thanks.

jonhadfield commented 8 years ago

Merged. Thanks. The shippable issue was that it runs as root by default, so it doesn't raise the expected exception. I've disabled that specific test for when it runs as root but will look to configure shippable to run as a different user.