jonhoo / buzz

A simple system tray application for notifying about unseen e-mail

Apache License 2.0

138 stars 12 forks source link

Run CI on PRs #16

Closed LiHRaM closed 4 years ago

LiHRaM commented 4 years ago

15 Yes, my bad. This should run on everything.

Edit: It really is too bad it's not Hacktoberfest :'D

jonhoo commented 4 years ago

Is there a way to mark the failing tests (macOS and Windows) as "allowed failures" somehow?

LiHRaM commented 4 years ago

As far as I can tell from the reference, continue-on-error allows the workflow itself to pass even though individual jobs do not. I've set that for all of the instances of check, although I think I can mark it for only the windows / macOS ones. Gotta put my son to sleep, and then I'll get on it. :D

LiHRaM commented 4 years ago

This is surprising behavior, because in the actions tab, the workflows are marked as successful, but in the commit history they are marked as failed. :(

jonhoo commented 4 years ago

Yeah, sadly I've seen this happen before with Actions. It's okay — good enough for now. I just won't mark them as required! Thanks again!