jonhoo / buzz

A simple system tray application for notifying about unseen e-mail
Apache License 2.0
138 stars 12 forks source link

Switch from systray to tray-item package #25

Closed DanielVoogsgerd closed 10 months ago

DanielVoogsgerd commented 1 year ago

This does a minimal change from the systray package to the tray-item package. The implementation can still be cleaned up a bit, but let's check first how well this works.

The implementation drops libappindicator support and switches to KSNI on Linux.

I'm not against the inclusion of the libappindicator support, however I think this would need a GTK event loop.

I tested this on waybar, and it seems to work for me. Furthermore, I think the old implementation did not work on Windows and macOS, this one might.

~fix~see also: #6

EDIT: Changed the fix reference to see also, as it does not entirely fix this issue. It just makes it easier to implement it.

jonhoo commented 11 months ago

I'd also love to hear from someone who can test this on X with an X tray (like polybar). I don't know if there's support for things like KSNI there?

DanielVoogsgerd commented 11 months ago

This also drops support for the right-click menu with the "Quit" option, but I think that's probably okay.

I did not realise that was in there, I think I can add it back with this package as well.

Otherwise, this looks nice and straightforward! I'm trying to decide whether this warrants a major version bump or not... It feels like maybe it does?

I'd say it's a grey area, not much a user can do from a maintenance perspective. If you were to bump the version, I'd suggest we first check for some other things that might warrant a major version bump as well.

For example, my other PR is implemented in a backward compatible way right now, but I'd say it's nicer to change the config a bit, the same goes for a change like: #6, which I still think is an improvement structurewise.

jonhoo commented 11 months ago

Yep, agreed, let's go ahead and make some of those config changes in a new release too!

DanielVoogsgerd commented 10 months ago

I am completely swamped right now, but probably have some time over the holidays to get the changes in.

jonhoo commented 10 months ago

Released as 1.7.0-rc.3 :tada: