jonhoo / faktory-rs

Rust bindings for Faktory clients and workers
Apache License 2.0
204 stars 16 forks source link

Add "tls' feature workflow and basic test #53

Closed rustworthy closed 8 months ago

rustworthy commented 9 months ago

Why macos runner excluded? It's super annoying :( Some runs will go [fine] (https://github.com/jonhoo/faktory-rs/actions/runs/7773048733/job/21196231638), another will fail with network error, or even worse - both will fail with the same connection refused. Also a tweak would be needed in the test like this:

let connector = if cfg!(target_os = "macos") {
            TlsConnector::builder()
                // Danger! Only for testing!
                // On the macos CI runner, the certs are not trusted:
                // { code: -67843, message: "The certificate was not trusted." }
                .danger_accept_invalid_certs(true)
                .build()
                .unwrap()
        } else { /* ..add the server cert to root certs .. */ }

So, not ideal, but staying the ubuntu-latest runner with stable and beta channels tested


This change is Reviewable

jonhoo commented 8 months ago

Released in 0.12.5 :tada: