jonhoo / faktory-rs

Rust bindings for Faktory clients and workers
Apache License 2.0
205 stars 16 forks source link

Add tracing and examples for `run` and `run_to_completion` #66

Closed rustworthy closed 4 months ago

rustworthy commented 6 months ago

This PR is also adding:


This change is Reviewable

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.0%. Comparing base (a4832db) to head (9974a67).

Additional details and impacted files | [Files](https://app.codecov.io/gh/jonhoo/faktory-rs/pull/66?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/worker/health.rs](https://app.codecov.io/gh/jonhoo/faktory-rs/pull/66?src=pr&el=tree&filepath=src%2Fworker%2Fhealth.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3dvcmtlci9oZWFsdGgucnM=) | `77.2% <87.5%> (+1.6%)` | :arrow_up: |
rustworthy commented 6 months ago

@jonhoo Please have a look at this PR once again.

The tests are actually failing for the main branch, which is will be fixed in a dedicated PR: we simply need to adjust a couple of tests to use Client::current_info instead of the retired Client::info.

UPDATE: addressed in #68