search

jonhoo / fantoccini

A high-level API for programmatically interacting with web pages through WebDriver.
Apache License 2.0
1.68k stars 125 forks source link

String + &String fix #198

Closed tomaspecl closed 1 year ago

tomaspecl commented 1 year ago

Fix for issue #196

jonhoo commented 1 year ago

Looks like a CI check failed. Also, @stevepryde in case you want to take a look.

codecov[bot] commented 1 year ago

Codecov Report

Merging #198 (f0cd2a5) into main (aa34add) will decrease coverage by 0.04%. The diff coverage is 32.46%.

Additional details and impacted files | [Impacted Files](https://codecov.io/gh/jonhoo/fantoccini/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/key.rs](https://codecov.io/gh/jonhoo/fantoccini/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2tleS5ycw==) | `51.37% <32.46%> (-1.31%)` | :arrow_down: |
stevepryde commented 1 year ago

Looks like a CI check failed. Also, @stevepryde in case you want to take a look.

Looks like a formatting issue? @tomaspecl

tomaspecl commented 1 year ago

Well I guess I could have done the fmt fix 2 weeks ago. I hope its alright now.

jonhoo commented 1 year ago

Yep, looks good! The minimal-versions thing isn't due to your change.

jonhoo commented 1 year ago

Released in rc4 :tada: