Closed jackdfraser closed 1 year ago
I guess I'm not quite clear on how much value this really provides — it's not as though there's lots of boilerplate to setting up the tests, and it's pretty easy to do it through a regular function (see our own test suite). If anything, I think I'd want this to live in a separate crate in its own repo. I don't think it's something that needs to live in fantoccini itself.
Merging #212 (eb4d2fe) into main (377e40b) will decrease coverage by
1.14%
. The diff coverage is0.00%
.
This PR is an attempt to introduce an attribute macro for testing with fantoccini as a dev dependency.
Essentially:
Upon being run the test will duplicate the test logic and run it against both
chromedriver
andgeckodriver
.Ideally generating:
Requirements:
tokio
,serial_test
andfantoccini
asdev-dependencies
.Notes:
tester!
macro.Areas Of Review Requested:
rustls
feature and usedClientbuilder::native()
. Why would someone use one vs the other?session_id
Arc<Mutex>
it wasn't clear to me that the code was making use of thesession_id
although perhaps that has something to do with my inexperience coding threads.Future Features:
"chrome:9515"
and"firefox:4444"
and parse out the port numbers.