search

jonhoo / fantoccini

A high-level API for programmatically interacting with web pages through WebDriver.
Apache License 2.0
1.68k stars 125 forks source link

IE mode of the msedge works #215

Closed mishan88 closed 1 year ago

mishan88 commented 1 year ago

Fixes #214

Proposed Changes

jonhoo commented 1 year ago

Ah, so, I don't actually want to remove this block — it's needed for Google Chrome support. Instead, I want to just not run the block if se:ieOptions is set in caps (so just place the block you removed inside an if instead).

mishan88 commented 1 year ago

Sorry. I misunderstood your intention. I'll rewrite later.

mishan88 commented 1 year ago

I rewrote. If capabilities' browserName is chrome, add goog:chromeOptions.

jonhoo commented 1 year ago

Excellent, thank you! I left a comment.

codecov[bot] commented 1 year ago

Codecov Report

Merging #215 (53565a1) into main (377e40b) will decrease coverage by 0.21%. The diff coverage is 28.57%.

:exclamation: Current head 53565a1 differs from pull request most recent head a97a0c2. Consider uploading reports for the commit a97a0c2 to get more accurate results

Additional details and impacted files | [Impacted Files](https://codecov.io/gh/jonhoo/fantoccini/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/session.rs](https://codecov.io/gh/jonhoo/fantoccini/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3Nlc3Npb24ucnM=) | `72.04% <28.57%> (-0.74%)` | :arrow_down: |
jonhoo commented 1 year ago

Thank you!