search

jonhoo / fantoccini

A high-level API for programmatically interacting with web pages through WebDriver.
Apache License 2.0
1.68k stars 125 forks source link

fix: Encapsulate `Wcmd` within a private wrapper #275

Open surajk-m opened 2 months ago

surajk-m commented 2 months ago

Closes #225

The change encapsulates Wcmd within a private wrapper.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.33%. Comparing base (29bbfa7) to head (0dd402d). Report is 1 commits behind head on main.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/jonhoo/fantoccini/pull/275?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/session.rs](https://app.codecov.io/gh/jonhoo/fantoccini/pull/275?src=pr&el=tree&filepath=src%2Fsession.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3Nlc3Npb24ucnM=) | `73.53% <100.00%> (-0.05%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/jonhoo/fantoccini/pull/275/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset)
jonhoo commented 4 weeks ago

Just a heads up that I'll be on holiday for the next three weeks, so won't have a chance to land this until I get back :)

surajk-m commented 3 weeks ago

No worries! Wishing you a great holiday. We’ll pick this up when you're back. 😊 Safe travels!