jonhoo / inferno

A Rust port of FlameGraph
Other
1.68k stars 125 forks source link

Switch test case to not handle arbitrarily large input #199

Closed austinabell closed 3 years ago

austinabell commented 3 years ago

My apologies for not noticing this test was really slow when I added support in #196, I didn't consider this was how the test was setup

codecov[bot] commented 3 years ago

Codecov Report

Merging #199 (8b53a81) into master (de3f7d9) will decrease coverage by 0.29%. The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   90.38%   90.08%   -0.30%     
==========================================
  Files          17       17              
  Lines        2235     2239       +4     
==========================================
- Hits         2020     2017       -3     
- Misses        215      222       +7     
Impacted Files Coverage Δ
src/collapse/common.rs 60.26% <0.00%> (-2.57%) :arrow_down:
src/collapse/dtrace.rs 91.54% <100.00%> (+0.32%) :arrow_up:
src/collapse/perf.rs 97.35% <100.00%> (+0.01%) :arrow_up:
src/collapse/sample.rs 95.95% <100.00%> (+0.08%) :arrow_up:
src/collapse/vtune.rs 94.52% <100.00%> (+0.15%) :arrow_up:
src/differential/mod.rs 98.36% <100.00%> (+0.02%) :arrow_up:
src/flamegraph/attrs.rs 93.75% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a78b3b8...8b53a81. Read the comment docs.

austinabell commented 3 years ago

I also noticed you have a CHANGELOG, would you like me to add a point about the change from #196 while I'm here?

jonhoo commented 3 years ago

Oh wow, yeah, that does seem like a weird way for it to test things.

And yes, a changelog entry would be awesome :+1: